fix(input): apply directives to only suitable inputs #6243
Conversation
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
| @@ -90,6 +90,7 @@ var inputType = { | |||
| </doc:example> | |||
| */ | |||
| 'text': textInputType, | |||
| 'textarea': textInputType, | |||
There was a problem hiding this comment.
What? Afaik there is no input[type=textarea], only the textarea element.
We want to use textInputType for textarea elements, so...
There was a problem hiding this comment.
You're right, but at least in chrome (the only browser I tested with), the "type" property of a <textarea> is "textarea". This directive is applied to <textarea> elements as well as <input> elements, so this was added to catch those.
There was a problem hiding this comment.
ah I see. I'm not totally sure if that will work for IE, but I guess we'll see. (In review I usually scan the diff from top to bottom, hadn't noticed you were using the property rather than attribute yet ;)
|
I'm not really sure how to recover this PR, since I basically want to change the proposed change altogether. I'm going to create another branch and submit a PR from that one. |
|
@twhitbeck if you want to make changes to an existing PR, you can simply make them and push your changes up to GitHub. At the point any PR is going to be accepted, though, you'll have to "squash" your commits into a single commit with a properly formatted commit message. All of that said, what problem is this PR attempting to solve? Not being snarky, I just didn't glean what the problem is from the conversation or the code. |
|
Ah, I didn't see that issue. That's precisely what's going on. I want to write my own |
No description provided.